aboutsummaryrefslogtreecommitdiffstats
path: root/scalding/src/test/scala
diff options
context:
space:
mode:
authorEllen Spertus <ellen.spertus@gmail.com>2018-06-04 14:45:26 -0700
committerEllen Spertus <ellen.spertus@gmail.com>2018-06-04 14:45:26 -0700
commit9a18da82738c16d3066e02e886ee84e04156889f (patch)
treebc6af643cb99a0679d36a6d8c386dbc47aa62a0e /scalding/src/test/scala
parentf2a0d6fe40be3a9b282a4cc0ea0ebdb85810762b (diff)
downloadsandcrawler-9a18da82738c16d3066e02e886ee84e04156889f.tar.gz
sandcrawler-9a18da82738c16d3066e02e886ee84e04156889f.zip
Made changes suggested in merge request review.
- Changed inverseSchema from Map to List, eliminating incorrect comment. - Changing format of argument to HBaseBuilder.build from String to List[String].
Diffstat (limited to 'scalding/src/test/scala')
-rw-r--r--scalding/src/test/scala/sandcrawler/HBaseBuilderTest.scala10
1 files changed, 5 insertions, 5 deletions
diff --git a/scalding/src/test/scala/sandcrawler/HBaseBuilderTest.scala b/scalding/src/test/scala/sandcrawler/HBaseBuilderTest.scala
index 8392100..b45751d 100644
--- a/scalding/src/test/scala/sandcrawler/HBaseBuilderTest.scala
+++ b/scalding/src/test/scala/sandcrawler/HBaseBuilderTest.scala
@@ -6,7 +6,7 @@ import sandcrawler.HBaseBuilder
class HBaseBuilderTest extends FlatSpec with Matchers {
"parseColSpec()" should "work on legal nontrivial input" in {
- val (fams, fields) = HBaseBuilder.parseColSpec("file:size, file:cdx, match0:status")
+ val (fams, fields) = HBaseBuilder.parseColSpec(List("file:size", "file:cdx", "match0:status"))
fams should have length 2
fields should have length 2
val fileIndex = fams.indexOf("file")
@@ -18,26 +18,26 @@ class HBaseBuilderTest extends FlatSpec with Matchers {
}
it should "work on empty input" in {
- val (fams, fields) = HBaseBuilder.parseColSpec("")
+ val (fams, fields) = HBaseBuilder.parseColSpec(List())
fams should have length 0
fields should have length 0
}
it should "throw IllegalArgumentException on malformed input" in {
a [IllegalArgumentException] should be thrownBy {
- HBaseBuilder.parseColSpec("file_size")
+ HBaseBuilder.parseColSpec(List("file_size"))
}
}
it should "throw IllegalArgumentException on nonexistent family" in {
a [IllegalArgumentException] should be thrownBy {
- HBaseBuilder.parseColSpec("foo:bar")
+ HBaseBuilder.parseColSpec(List("foo:bar"))
}
}
it should "throw IllegalArgumentException on nonexistent column" in {
a [IllegalArgumentException] should be thrownBy {
- HBaseBuilder.parseColSpec("file:bar")
+ HBaseBuilder.parseColSpec(List("file:bar"))
}
}
}