diff options
| author | Bryan Newbold <bnewbold@robocracy.org> | 2020-10-08 18:37:03 -0700 |
|---|---|---|
| committer | Bryan Newbold <bnewbold@robocracy.org> | 2020-10-08 18:37:03 -0700 |
| commit | 27fe31d5ffcac700c30b2b10d56685ef0fa4f3a8 (patch) | |
| tree | d4350b662bb33e9dcc9576951d16adec3f901bb1 | |
| parent | e3320e27999567ec9b687c25cc8040ff600496cd (diff) | |
| download | fatcat-27fe31d5ffcac700c30b2b10d56685ef0fa4f3a8.tar.gz fatcat-27fe31d5ffcac700c30b2b10d56685ef0fa4f3a8.zip | |
chocula importer: small tweaks to update behavior
| -rw-r--r-- | python/fatcat_tools/importers/chocula.py | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/python/fatcat_tools/importers/chocula.py b/python/fatcat_tools/importers/chocula.py index d08a98e0..63290453 100644 --- a/python/fatcat_tools/importers/chocula.py +++ b/python/fatcat_tools/importers/chocula.py @@ -112,9 +112,9 @@ class ChoculaImporter(EntityImporter): return False if not existing.extra: existing.extra = dict() - if set(ce.extra.get('urls', [])) != set(existing.extra.get('urls', [])): + if ce.extra.get('urls') and set(ce.extra.get('urls', [])) != set(existing.extra.get('urls', [])): do_update = True - if set(ce.extra.get('webarchive_urls', [])) != set(existing.extra.get('webarchive_urls', [])): + if ce.extra.get('webarchive_urls') and set(ce.extra.get('webarchive_urls', [])) != set(existing.extra.get('webarchive_urls', [])): do_update = True for k in ('ezb', 'szczepanski', 'publisher_type', 'platform'): if ce.extra.get(k) and not existing.extra.get(k): @@ -133,12 +133,10 @@ class ChoculaImporter(EntityImporter): existing.publisher = existing.publisher or ce.publisher existing.container_type = existing.container_type or ce.container_type for k in ('urls', 'webarchive_urls'): - # always update if available. should probably make this more - # careful/subtle in the future! - # note: in some cases we might *want* to remove existing (if - # all URLs found to be bad), but being - # conservative/inclusionist for now - if ce.extra.get(k): + # be conservative about URL updates; don't clobber existing URL lists + # may want to make this behavior more sophisticated in the + # future, or at least a config flag + if ce.extra.get(k) and not existing.extra.get(k): existing.extra[k] = ce.extra.get(k, []) for k in ('sherpa_romeo', 'ezb', 'szczepanski', 'doaj', 'ia', 'scielo', 'kbart', 'publisher_type', 'platform'): |