diff options
author | Ellen Spertus <ellen.spertus@gmail.com> | 2018-07-19 15:21:33 -0700 |
---|---|---|
committer | Ellen Spertus <ellen.spertus@gmail.com> | 2018-07-19 15:55:43 -0700 |
commit | ce5cbe4a581ae0a41e988dd3b396ee667b2e63ce (patch) | |
tree | 3d0ee185b19b785825350de9c371549919c02ab6 /scalding/scalastyle-config.xml | |
parent | 2f39ba88482ba47a03fc52edcae891755ecb2b4d (diff) | |
download | sandcrawler-ce5cbe4a581ae0a41e988dd3b396ee667b2e63ce.tar.gz sandcrawler-ce5cbe4a581ae0a41e988dd3b396ee667b2e63ce.zip |
Improved style and style checking.
- Excludes checking of files in /example directories.
- Warns about block imports, which have been removed.
- Checks indenting. Parameters should be indented 2 spaces. See https://docs.scala-lang.org/style/indentation.html#methods-with-numerous-arguments
- Imports should be grouped (java.*, scala.*, other), with a blank line between groups
Diffstat (limited to 'scalding/scalastyle-config.xml')
-rw-r--r-- | scalding/scalastyle-config.xml | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/scalding/scalastyle-config.xml b/scalding/scalastyle-config.xml index e2f58a0..adf9b0f 100644 --- a/scalding/scalastyle-config.xml +++ b/scalding/scalastyle-config.xml @@ -6,6 +6,13 @@ <parameter name="maxFileLength"><![CDATA[800]]></parameter> </parameters> </check> +<check enabled="true" class="org.scalastyle.file.IndentationChecker" level="warning"> + <parameters> + <parameter name="tabSize">2</parameter> + <parameter name="methodParamIndentSize">2</parameter> + <parameter name="classParamIndentSize">4</parameter> + </parameters> +</check> <check level="warning" class="org.scalastyle.file.HeaderMatchesChecker" enabled="false"> <parameters> <parameter name="header"><![CDATA[// Copyright (C) 2011-2012 the original author or authors. @@ -50,11 +57,6 @@ </parameters> </check> <check level="warning" class="org.scalastyle.scalariform.EqualsHashCodeChecker" enabled="true"></check> - <check level="warning" class="org.scalastyle.scalariform.IllegalImportsChecker" enabled="true"> - <parameters> - <parameter name="illegalImports"><![CDATA[sun._,java.awt._]]></parameter> - </parameters> - </check> <check level="warning" class="org.scalastyle.scalariform.ParameterNumberChecker" enabled="true"> <parameters> <parameter name="maxParameters"><![CDATA[8]]></parameter> @@ -124,5 +126,10 @@ <parameter name="maxBlankLines">1</parameter> <parameter name="lexicographic">true</parameter> </parameters> +</check> +<check level="warning" class="org.scalastyle.scalariform.IllegalImportsChecker" enabled="true"> + <parameters> + <parameter name="illegalImports"><![CDATA[sun._,java.awt._]]></parameter> + </parameters> </check> </scalastyle> |