From 11f7c22e1de104918d32274feaea310c11476cc7 Mon Sep 17 00:00:00 2001 From: Bryan Newbold Date: Tue, 24 Mar 2020 13:19:02 -0700 Subject: ia: more conservative use of clean_url() Fixes AttributeError: 'NoneType' object has no attribute 'strip' Seen in production on the lookup_resource code path. --- python/sandcrawler/ia.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'python') diff --git a/python/sandcrawler/ia.py b/python/sandcrawler/ia.py index cc176d0..510f23e 100644 --- a/python/sandcrawler/ia.py +++ b/python/sandcrawler/ia.py @@ -543,8 +543,8 @@ class WaybackClient: if redirect_url and redirect_url.startswith("https://web.archive.org/web/"): redirect_url = "/".join(redirect_url.split("/")[5:]) #print(redirect_url, file=sys.stderr) - redirect_url = clean_url(redirect_url) if redirect_url and redirect_url.startswith("http"): + redirect_url = clean_url(redirect_url) return redirect_url else: return None @@ -667,13 +667,15 @@ class WaybackClient: next_url = domain_prefix + resource.location else: next_url = resource.location - next_url = clean_url(next_url) + if next_url: + next_url = clean_url(next_url) else: next_url = self.fetch_replay_redirect( url=cdx_row.url, datetime=cdx_row.datetime, ) - next_url = clean_url(next_url) + if next_url: + next_url = clean_url(next_url) cdx_row = cdx_partial_from_row(cdx_row) if not next_url: print("bad redirect record: {}".format(cdx_row), file=sys.stderr) -- cgit v1.2.3