From cc8a5cbaad299c0cfbf730042014cf12bc0cb975 Mon Sep 17 00:00:00 2001 From: Marti Bolivar Date: Fri, 1 Jun 2012 01:29:54 -0400 Subject: stm32f2/usart.c: Change some FIXMEs to TODOs. I think these are probably unchanged, but we need to make sure. Signed-off-by: Marti Bolivar --- libmaple/stm32f2/usart.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libmaple/stm32f2/usart.c b/libmaple/stm32f2/usart.c index e4fc9b1..2dd3afc 100644 --- a/libmaple/stm32f2/usart.c +++ b/libmaple/stm32f2/usart.c @@ -42,7 +42,7 @@ static ring_buffer usart1_rb; static usart_dev usart1 = { .regs = USART1_BASE, .rb = &usart1_rb, - .max_baud = 4500000UL, /* FIXME */ + .max_baud = 4500000UL, /* TODO: are these correct? */ .clk_id = RCC_USART1, .irq_num = NVIC_USART1, }; @@ -53,7 +53,7 @@ static ring_buffer usart2_rb; static usart_dev usart2 = { .regs = USART2_BASE, .rb = &usart2_rb, - .max_baud = 2250000UL, /* FIXME */ + .max_baud = 2250000UL, /* TODO: are these correct? */ .clk_id = RCC_USART2, .irq_num = NVIC_USART2, }; @@ -64,7 +64,7 @@ static ring_buffer usart3_rb; static usart_dev usart3 = { .regs = USART3_BASE, .rb = &usart3_rb, - .max_baud = 2250000UL, /* FIXME */ + .max_baud = 2250000UL, /* TODO: are these correct? */ .clk_id = RCC_USART3, .irq_num = NVIC_USART3, }; @@ -75,7 +75,7 @@ static ring_buffer uart4_rb; static usart_dev uart4 = { .regs = UART4_BASE, .rb = &uart4_rb, - .max_baud = 2250000UL, /* FIXME */ + .max_baud = 2250000UL, /* TODO: are these correct? */ .clk_id = RCC_UART4, .irq_num = NVIC_UART4, }; @@ -86,7 +86,7 @@ static ring_buffer uart5_rb; static usart_dev uart5 = { .regs = UART5_BASE, .rb = &uart5_rb, - .max_baud = 2250000UL, /* FIXME */ + .max_baud = 2250000UL, /* TODO: are these correct? */ .clk_id = RCC_UART5, .irq_num = NVIC_UART5, }; @@ -97,7 +97,7 @@ static ring_buffer usart6_rb; static usart_dev usart6 = { .regs = USART6_BASE, .rb = &usart6_rb, - .max_baud = 4500000UL, /* FIXME */ + .max_baud = 4500000UL, /* TODO: are these correct? */ .clk_id = RCC_USART6, .irq_num = NVIC_USART6, }; @@ -112,6 +112,7 @@ void usart_async_gpio_cfg(usart_dev *udev, gpio_dev *tx_dev, uint8 tx, unsigned flags) { gpio_af af; + /* TODO: break this out into a user-facing function. */ switch (udev->clk_id) { case RCC_USART1: case RCC_USART2: -- cgit v1.2.3