diff options
| author | Bryan Newbold <bnewbold@robocracy.org> | 2017-10-26 20:10:00 -0700 |
|---|---|---|
| committer | Bryan Newbold <bnewbold@robocracy.org> | 2017-10-26 20:10:00 -0700 |
| commit | 252ecdeeae6847f44bec5eeb5919040c9bce9ca9 (patch) | |
| tree | c800a26d204efa6333e1b9c86936a9b0f6869bb0 | |
| parent | 258027d0b02fe0cddc3bdf9774fb6bddb2b1c444 (diff) | |
| download | geniza-252ecdeeae6847f44bec5eeb5919040c9bce9ca9.tar.gz geniza-252ecdeeae6847f44bec5eeb5919040c9bce9ca9.zip | |
additions to notes
| -rw-r--r-- | notes/spec_todo.txt | 15 | ||||
| -rw-r--r-- | notes/upstream_behavior.txt | 27 |
2 files changed, 27 insertions, 15 deletions
diff --git a/notes/spec_todo.txt b/notes/spec_todo.txt index 40c59f5..7630a68 100644 --- a/notes/spec_todo.txt +++ b/notes/spec_todo.txt @@ -32,18 +32,3 @@ inefficient... fixed 32-bit length makes more sense to me, seems like efficiency gains would be pretty small. would need benchmarking. https://developers.google.com/protocol-buffers/docs/techniques#streaming - -### Small Bugs - -hypercore: 'Request' without 'Have' crashes dat, despite whitepaper saying "You -should only send Have messages to peers who have expressed interest in this -region with Want messages.": - - /usr/lib/node_modules/dat/node_modules/hypercore/lib/replicate.js:119 - if (!self.remoteBitfield.set(request.index, true)) return - ^ - - TypeError: Cannot read property 'set' of null - at onvalue (/usr/lib/node_modules/dat/node_modules/hypercore/lib/replicate.js:119:33) - at onread (/usr/lib/node_modules/dat/node_modules/random-access-file/index.js:130:14) - at FSReqWrap.wrapper [as oncomplete] (fs.js:629:17) diff --git a/notes/upstream_behavior.txt b/notes/upstream_behavior.txt new file mode 100644 index 0000000..c5ba8e2 --- /dev/null +++ b/notes/upstream_behavior.txt @@ -0,0 +1,27 @@ + +hypercore: 'Request' without 'Have' crashes dat, despite whitepaper saying "You +should only send Have messages to peers who have expressed interest in this +region with Want messages.": + + /usr/lib/node_modules/dat/node_modules/hypercore/lib/replicate.js:119 + if (!self.remoteBitfield.set(request.index, true)) return + ^ + + TypeError: Cannot read property 'set' of null + at onvalue (/usr/lib/node_modules/dat/node_modules/hypercore/lib/replicate.js:119:33) + at onread (/usr/lib/node_modules/dat/node_modules/random-access-file/index.js:130:14) + at FSReqWrap.wrapper [as oncomplete] (fs.js:629:17) + +dat-network seems to keep trying to send data every 30 seconds even if remote +client has disconnected: + + [...] + dat-network Uploaded data: 984105 +500ms + dat-network Uploaded data: 984105 +500ms + dat-network Uploaded data: 984105 +501ms + dat-network Uploaded data: 984105 +499ms + dat-network Uploaded data: 984105 +501ms + dat-network Uploaded data: 984105 +500ms + dat-network Uploaded data: 984105 +500ms + [...] + |