From 938209d5a6011066a23f3ca9f1c85beeb8b400a6 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 14 May 2020 00:06:10 +0200 Subject: Indentity is not the same this as equality in Python --- python/tests/harvest_state.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'python') diff --git a/python/tests/harvest_state.py b/python/tests/harvest_state.py index 85cd2c99..da9bef84 100644 --- a/python/tests/harvest_state.py +++ b/python/tests/harvest_state.py @@ -11,7 +11,7 @@ def test_harvest_state(): hs = HarvestState(catchup_days=5) assert max(hs.to_process) < today - assert len(hs.to_process) is 5 + assert len(hs.to_process) == 5 for d in list(hs.to_process): hs.complete(d) @@ -22,12 +22,12 @@ def test_harvest_state(): start_date=datetime.date(2000,1,1), end_date=datetime.date(2000,1,3), ) - assert len(hs.to_process) is 3 + assert len(hs.to_process) == 3 hs = HarvestState( start_date=datetime.date(2000,1,29), end_date=datetime.date(2000,2,2), ) - assert len(hs.to_process) is 5 + assert len(hs.to_process) == 5 hs = HarvestState(catchup_days=0) assert hs.next() is None @@ -35,6 +35,6 @@ def test_harvest_state(): start_date=datetime.date(2000,1,1), end_date=datetime.date(2000,1,3), ) - assert len(hs.to_process) is 3 + assert len(hs.to_process) == 3 hs.update('{"completed-date": "2000-01-02"}') - assert len(hs.to_process) is 2 + assert len(hs.to_process) == 2 -- cgit v1.2.3 From 00a741f9268988eb0afa62099cd404f1a1d0777f Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 14 May 2020 00:07:17 +0200 Subject: Indentity is not the same this as equality in Python --- python/fatcat_tools/importers/jalc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'python') diff --git a/python/fatcat_tools/importers/jalc.py b/python/fatcat_tools/importers/jalc.py index c2adc0d6..e30bb233 100644 --- a/python/fatcat_tools/importers/jalc.py +++ b/python/fatcat_tools/importers/jalc.py @@ -201,11 +201,11 @@ class JalcImporter(EntityImporter): date = record.date or None if date: date = date.string - if len(date) is 10: + if len(date) == 10: release_date = datetime.datetime.strptime(date['completed-date'], DATE_FMT).date() release_year = release_date.year release_date = release_date.isoformat() - elif len(date) is 4 and date.isdigit(): + elif len(date) == 4 and date.isdigit(): release_year = int(date) pages = None -- cgit v1.2.3