From ec15f162706da58c464b5c2b7b623920fcb96d7f Mon Sep 17 00:00:00 2001
From: Bryan Newbold <bnewbold@robocracy.org>
Date: Wed, 25 Mar 2020 12:56:36 -0700
Subject: improve citeproc/CSL web interface

This tries to show the citeproc (bibtext, MLA, CSL-JSON) options for
more releases, and not show the links when they would break.

The primary motivation here is to work around two exceptions being
thrown in prod every day (according to sentry):

  KeyError: 'role'
  ValueError: CLS requries some surname (family name)

I'm guessing these are mostly coming from crawlers following the
citeproc links on release landing pages.
---
 python/fatcat_web/entity_helpers.py           | 7 ++++++-
 python/fatcat_web/templates/release_view.html | 3 +--
 2 files changed, 7 insertions(+), 3 deletions(-)

(limited to 'python/fatcat_web')

diff --git a/python/fatcat_web/entity_helpers.py b/python/fatcat_web/entity_helpers.py
index 591dda80..009f6160 100644
--- a/python/fatcat_web/entity_helpers.py
+++ b/python/fatcat_web/entity_helpers.py
@@ -74,8 +74,13 @@ def enrich_release_entity(entity):
             ref.extra['unstructured'] = strip_extlink_xml(ref.extra['unstructured'])
     # author list to display; ensure it's sorted by index (any othors with
     # index=None go to end of list)
-    authors = [c for c in entity.contribs if c.role in ('author', None)]
+    authors = [c for c in entity.contribs if
+        c.role in ('author', None) and
+        (c.surname or c.raw_name or (c.creator and c.creator.surname))
+    ]
     entity._authors = sorted(authors, key=lambda c: (c.index == None and 99999999) or c.index)
+    # need authors, title for citeproc to work
+    entity._can_citeproc = bool(entity._authors) and bool(entity.title)
     if entity.abstracts:
         # hack to show plain text instead of latex abstracts
         if 'latex' in entity.abstracts[0].mimetype:
diff --git a/python/fatcat_web/templates/release_view.html b/python/fatcat_web/templates/release_view.html
index 961b4759..d7c4e76e 100644
--- a/python/fatcat_web/templates/release_view.html
+++ b/python/fatcat_web/templates/release_view.html
@@ -388,8 +388,7 @@ accessible version.
   <br>grouping other versions (eg, pre-print) and variants of this release
 </div>
 
-{# this restriction, for CSL-JSON generation, rules out almost everything #}
-{% if release.contribs and release.contribs[0].creator_id %}
+{% if release._can_citeproc %}
 <div class="ui segment attached accordion">
   <div class="title" style="padding: 0px;">
     <i class="dropdown icon"></i><b>Cite This Release</b>
-- 
cgit v1.2.3