From 5d29d1336afc90d3575a0379a9e9d9bdac8d1856 Mon Sep 17 00:00:00 2001
From: Bryan Newbold <bnewbold@robocracy.org>
Date: Wed, 3 Nov 2021 13:57:18 -0700
Subject: typing: relatively simple type check fixes

These mostly add new variable names so that existing variables aren't
overwritten with a new type; delay coercing '{}' or '[]' to 'None' until
the last minute; adding is-not-None checks to conditional clauses; and
similar small changes.
---
 python/fatcat_tools/importers/pubmed.py | 24 +++++++-----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

(limited to 'python/fatcat_tools/importers/pubmed.py')

diff --git a/python/fatcat_tools/importers/pubmed.py b/python/fatcat_tools/importers/pubmed.py
index 41268925..d32fcefa 100644
--- a/python/fatcat_tools/importers/pubmed.py
+++ b/python/fatcat_tools/importers/pubmed.py
@@ -495,12 +495,12 @@ class PubmedImporter(EntityImporter):
             release_year = int(pub_date.Year.string)
             if pub_date.find("Day") and pub_date.find("Month"):
                 try:
-                    release_date = datetime.date(
+                    release_date_date = datetime.date(
                         release_year,
                         MONTH_ABBR_MAP[pub_date.Month.string],
                         int(pub_date.Day.string),
                     )
-                    release_date = release_date.isoformat()
+                    release_date = release_date_date.isoformat()
                 except ValueError as ve:
                     print("bad date, skipping: {}".format(ve), file=sys.stderr)
                     release_date = None
@@ -595,8 +595,6 @@ class PubmedImporter(EntityImporter):
             )
             if abst.content:
                 abstracts.append(abst)
-        if not abstracts:
-            abstracts = None
 
         ### Contribs
         contribs = []
@@ -663,8 +661,6 @@ class PubmedImporter(EntityImporter):
         for i, contrib in enumerate(contribs):
             if contrib.raw_name != "et al.":
                 contrib.index = i
-        if not contribs:
-            contribs = None
 
         ### References
         refs = []
@@ -692,16 +688,12 @@ class PubmedImporter(EntityImporter):
                 ref_raw = ref.Citation
                 if ref_raw:
                     ref_extra["unstructured"] = ref_raw.get_text()
-                if not ref_extra:
-                    ref_extra = None
                 refs.append(
                     fatcat_openapi_client.ReleaseRef(
                         target_release_id=ref_release_id,
-                        extra=ref_extra,
+                        extra=ref_extra or None,
                     )
                 )
-        if not refs:
-            refs = None
 
         # extra:
         #   translation_of
@@ -711,8 +703,6 @@ class PubmedImporter(EntityImporter):
         #   pubmed: retraction refs
         if extra_pubmed:
             extra["pubmed"] = extra_pubmed
-        if not extra:
-            extra = None
 
         title = clean(title)
         if not title:
@@ -739,11 +729,11 @@ class PubmedImporter(EntityImporter):
             # publisher  # not included?
             language=language,
             # license_slug   # not in MEDLINE
-            abstracts=abstracts,
-            contribs=contribs,
-            refs=refs,
+            abstracts=abstracts or None,
+            contribs=contribs or None,
+            refs=refs or None,
             container_id=container_id,
-            extra=extra,
+            extra=extra or None,
         )
         return re
 
-- 
cgit v1.2.3