From bf7725c00749e3560fa59711a02c229fa9b228d4 Mon Sep 17 00:00:00 2001
From: Bryan Newbold <bnewbold@robocracy.org>
Date: Tue, 29 Jan 2019 17:51:34 -0800
Subject: yet another required field bug

---
 python/fatcat_tools/importers/orcid.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/python/fatcat_tools/importers/orcid.py b/python/fatcat_tools/importers/orcid.py
index d54b5122..928b9627 100644
--- a/python/fatcat_tools/importers/orcid.py
+++ b/python/fatcat_tools/importers/orcid.py
@@ -56,18 +56,19 @@ class OrcidImporter(EntityImporter):
                 display = sur
             elif given:
                 display = given
-        if not display:
-            # must have *some* name
-            return None
         orcid = obj['orcid-identifier']['path']
         if not self.is_orcid(orcid):
             sys.stderr.write("Bad ORCID: {}\n".format(orcid))
             return None
+        display = clean(display)
+        if not display:
+            # must have *some* name
+            return None
         ce = fatcat_client.CreatorEntity(
             orcid=orcid,
             given_name=clean(given),
             surname=clean(sur),
-            display_name=clean(display),
+            display_name=display,
             extra=extra)
         return ce
 
-- 
cgit v1.2.3