From 657f7e93b0923b7be3612ff03998e5280d688f51 Mon Sep 17 00:00:00 2001 From: Martin Czygan Date: Fri, 2 Apr 2021 22:37:59 +0200 Subject: datacite: a missing surname should be None, not the empty string refs sentry #77700 --- python/fatcat_tools/importers/datacite.py | 3 +-- python/tests/files/datacite/datacite_result_33.json | 1 - python/tests/files/datacite/datacite_result_34.json | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/python/fatcat_tools/importers/datacite.py b/python/fatcat_tools/importers/datacite.py index 70f8db86..221ac8f5 100644 --- a/python/fatcat_tools/importers/datacite.py +++ b/python/fatcat_tools/importers/datacite.py @@ -869,8 +869,7 @@ class DataciteImporter(EntityImporter): if given_name: given_name = clean(given_name) - if surname: - surname = clean(surname) + surname = clean(surname) # Perform a final assertion that name does not reduce to zero # (e.g. whitespace only name). diff --git a/python/tests/files/datacite/datacite_result_33.json b/python/tests/files/datacite/datacite_result_33.json index bcb72469..cf6b8496 100644 --- a/python/tests/files/datacite/datacite_result_33.json +++ b/python/tests/files/datacite/datacite_result_33.json @@ -8,7 +8,6 @@ "contribs": [ { "given_name": "", - "surname": "", "index": 0, "raw_name": "ABC News", "role": "author" diff --git a/python/tests/files/datacite/datacite_result_34.json b/python/tests/files/datacite/datacite_result_34.json index 4a52e22c..85641157 100644 --- a/python/tests/files/datacite/datacite_result_34.json +++ b/python/tests/files/datacite/datacite_result_34.json @@ -8,7 +8,6 @@ "contribs": [ { "given_name": "", - "surname": "", "index": 0, "raw_name": "Paul Katz", "role": "author" -- cgit v1.2.3