summaryrefslogtreecommitdiffstats
path: root/python
Commit message (Collapse)AuthorAgeFilesLines
* remove isascii() work around definition in importers/datacite.pyBryan Newbold2020-07-231-7/+1
| | | | We are python3.7 now, so this isn't needed.
* simple lint (flake8) fixes over python codebaseBryan Newbold2020-07-237-19/+18
| | | | | | These should not have any behavior changes, though a number of exception catches are now more general, and there may be long-tail exceptions getting thrown in these statements.
* fix actual typo in tests (caught by lint)Bryan Newbold2020-07-231-2/+2
|
* simple lint (flake8) fixes in testsBryan Newbold2020-07-235-5/+4
| | | | | | The pytest fixture syntax interacts weirdly with flake8 tests, so ignore the "redefinition" and "unused variable" errors more carefully for .py files under ./tests/
* Merge branch 'martin-datacite-duplicated-author-gh-59' into 'master'bnewbold2020-07-1113-251/+619
|\ | | | | | | | | datacite: address duplicated contributor issue See merge request webgroup/fatcat!65
| * datacite: resolve formatting issues in testsMartin Czygan2020-07-1096-340/+182
| |\
| * | datacite: adjust testsMartin Czygan2020-07-104-10/+6
| | |
| * | datacite: there should be no index gapsMartin Czygan2020-07-101-2/+8
| | |
| * | datacite: document contributor typesMartin Czygan2020-07-101-0/+25
| | |
| * | wip: contrib, GH59Martin Czygan2020-07-102-245/+383
| | |
| * | wip: contrib, GH59Martin Czygan2020-07-105-3/+105
| | |
| * | datacite: address duplicated contributor issueMartin Czygan2020-07-076-11/+110
| | | | | | | | | | | | | | | | | | | | | Use string comparison. * https://fatcat.wiki/release/spjysmrnsrgyzgq6ise5o44rlu/contribs * https://api.datacite.org/dois/10.25940/roper-31098406
* | | Merge branch 'martin-datacite-bugfix-sentry-44035' into 'master'bnewbold2020-07-111-0/+4
|\ \ \ | |_|/ |/| | | | | | | | datacite: mitigate sentry #44035 See merge request webgroup/fatcat!66
| * | datacite: mitigate sentry #44035Martin Czygan2020-07-101-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to sentry, running `c.get('nameIdentifiers', []) or []` on a c with value: ``` {'affiliation': [], 'familyName': 'Guidon', 'givenName': 'Manuel', 'nameIdentifiers': {'nameIdentifier': 'https://orcid.org/0000-0003-3543-6683', 'nameIdentifierScheme': 'ORCID', 'schemeUri': 'https://orcid.org'}, 'nameType': 'Personal'} ``` results in a string, which I cannot reproduce. The document in question at: https://api.datacite.org/dois/10.26275/kuw1-fdls seems fine, too.
* | | Merge branch 'martin-arxiv-fix-http-503' into 'master'bnewbold2020-07-101-1/+1
|\ \ \ | | | | | | | | | | | | | | | | arxiv: address 503, "Retry after specified interval" error See merge request webgroup/fatcat!64
| * | | arxiv: do retry five times of HTTP 503Martin Czygan2020-07-101-1/+1
| | | |
* | | | get mediawiki username creation working with spacesBryan Newbold2020-07-091-1/+2
| |/ / |/| |
* | | datacite: fix attribute errorMartin Czygan2020-07-071-1/+1
|/ / | | | | | | refs: #44035
* | tweak flake8 paramsBryan Newbold2020-07-011-2/+8
| |
* | lint (flake8) python test filesBryan Newbold2020-07-0145-168/+71
| |
* | lint (flake8) tool python filesBryan Newbold2020-07-0133-130/+46
| |
* | lint (flake8) web interface python filesBryan Newbold2020-07-017-26/+16
| |
* | lint (flake8) top-level python filesBryan Newbold2020-07-018-25/+11
| |
* | updates to MakefileBryan Newbold2020-07-012-5/+32
| |
* | reviewer: fix bugs in common code found by mypyBryan Newbold2020-07-011-2/+3
| |
* | update TODO with some old examplesBryan Newbold2020-07-011-0/+10
|/
* add new license mappingsBryan Newbold2020-06-302-0/+27
|
* datacite: improve license mappingMartin Czygan2020-06-302-9/+29
| | | | via "missed potential license", refs #58
* datacite: hard cast possible date value to stringMartin Czygan2020-06-292-1/+2
|
* disallow a specific unicode character from DOIsBryan Newbold2020-06-261-0/+6
|
* make fulltext-only label clickableMartin Czygan2020-06-161-2/+2
|
* Merge branch 'bnewbold-better-button-links' into 'master'Martin Czygan2020-06-054-4/+18
|\ | | | | | | | | better download button links See merge request webgroup/fatcat!57
| * use ES 'best_url' in file download pagesBryan Newbold2020-06-042-2/+4
| | | | | | | | Similar to recent change for release download pages.
| * ES schema: add best_url to file schemaBryan Newbold2020-06-041-0/+12
| | | | | | | | | | | | | | | | | | This will increase index size (URLs are often long in our corpus, and we have many file entities), but seems worth it. Initially added `ia_url` as a second field, guaranteed to always be an *.archive.org URL, but `best_url` defaults to that anyways so didn't seem worthwhile.
| * re-use 'best pdf url' for release green buttonBryan Newbold2020-06-041-2/+2
| | | | | | | | | | | | | | I thought this was the existing behavior, but it looks like we were just taking the first link from the first file. In the future may refactor this out even further.
* | fix 'dev' target in python makefileBryan Newbold2020-06-041-1/+1
|/
* Merge remote-tracking branch 'origin/martin-harvest-fail-on-400'Bryan Newbold2020-05-291-4/+0
|\ | | | | | | | | | | Manually resolved conflicts: python/fatcat_tools/harvest/doi_registrars.py
| * harvest: fail on HTTP 400Martin Czygan2020-05-291-4/+0
| | | | | | | | | | | | | | | | | | In the past harvest of datacite resulted in occasional HTTP 400. Meanwhile, various API bugs have been fixed (most recently: https://github.com/datacite/lupo/pull/537, https://github.com/datacite/datacite/issues/1038). Downside of ignoring this error was that state lives in kafka, which has limited support for deletion of arbitrary messages from a topic.
* | Merge branch 'martin-datacite-harvest-log-output' into 'master'Martin Czygan2020-05-291-1/+1
|\ \ | | | | | | | | | | | | harvest: log the failed url See merge request webgroup/fatcat!55
| * | harvest: log the failed urlMartin Czygan2020-05-291-1/+1
| |/
* / datacite: fix test docsMartin Czygan2020-05-291-3/+3
|/
* Merge branch 'bnewbold-ingest-stage' into 'master'Martin Czygan2020-05-283-7/+46
|\ | | | | | | | | verify release_stage in ingest importer See merge request webgroup/fatcat!52
| * ingest importer: check that stage is consistent with releaseBryan Newbold2020-05-261-0/+5
| |
| * regression test for release_stage mismatch with ingest requestBryan Newbold2020-05-262-7/+41
| |
* | rename HarvestState.next() to HarvestState.next_span()Bryan Newbold2020-05-265-7/+7
|/ | | | | | | | | "span" short for "timespan" to harvest; there may be a better name to use. Motivation for this is to work around a pylint erorr that .next() was not callable. This might be a bug with pylint, but .next() is also a very generic name.
* add a work-in-progress python MakefileBryan Newbold2020-05-261-0/+24
|
* pylintrc: skip many spurious WTForm no-member errorsBryan Newbold2020-05-261-0/+2
|
* HACK: try to squelch pylint in CIBryan Newbold2020-05-261-2/+2
| | | | | | | | | | | | | | | | | Gitlab CI is showing lint errors like: =================================== FAILURES =================================== 6316 _______________________ [pylint] tests/harvest_state.py ________________________ 6317 E: 19,11: hs.next is not callable (not-callable) 6318 E: 33,11: hs.next is not callable (not-callable) 6319 E: 19,11: hs.next is not callable (not-callable) [...] this is confusing as we use pipenv with a lock, so I should see the exact same errors locally. This commit is a hack to try and fix this and unbreak builds until we can debug further.
* HACK: skip pylint errors on lines that seem to be fineBryan Newbold2020-05-223-3/+3
| | | | | It seems to be an inadvertantly ugraded version of pylint saying that these lines are not-callable.
* pipenv: add flake8Bryan Newbold2020-05-222-183/+213
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-11-04 11:00:28 +0000