| Commit message (Collapse) | Author | Age | Files | Lines | 
| | 
| 
| 
|  | 
We are python3.7 now, so this isn't needed.
 | 
| | 
| 
| 
| 
| 
|  | 
These should not have any behavior changes, though a number of exception
catches are now more general, and there may be long-tail exceptions
getting thrown in these statements.
 | 
| |\  
| | 
| | 
| | 
| |  | 
datacite: address duplicated contributor issue
See merge request webgroup/fatcat!65
 | 
| | |\   | 
 | 
| | | |  | 
 | 
| | | |  | 
 | 
| | | |  | 
 | 
| | | | 
| | | 
| | | 
| | | 
| | | 
| | | 
| | |  | 
Use string comparison.
* https://fatcat.wiki/release/spjysmrnsrgyzgq6ise5o44rlu/contribs
* https://api.datacite.org/dois/10.25940/roper-31098406
 | 
| | |/  
|/|   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |   
| |    | 
According to sentry, running `c.get('nameIdentifiers', []) or []` on a c with value:
```
{'affiliation': [],
 'familyName': 'Guidon',
 'givenName': 'Manuel',
 'nameIdentifiers': {'nameIdentifier': 'https://orcid.org/0000-0003-3543-6683',
                     'nameIdentifierScheme': 'ORCID',
                     'schemeUri': 'https://orcid.org'},
 'nameType': 'Personal'}
```
results in a string, which I cannot reproduce. The document in question at:
https://api.datacite.org/dois/10.26275/kuw1-fdls seems fine, too.
 | 
| | | 
| | 
| | 
| |  | 
refs: #44035
 | 
| |/   | 
 | 
| |  | 
 | 
| | 
| 
| 
|  | 
via "missed potential license", refs #58
 | 
| |  | 
 | 
| | 
| 
| 
| 
| 
| 
|  | 
Up to now, we expected the description to be a string or list. Add
handling for int as well.
First appeared: Apr 22 19:58:39.
 | 
| | 
| 
| 
| 
| 
| 
|  | 
It was possible that contribs got added which had no raw name. One
example would be a name consisting of whitespace only.
This fix adds a final check for this case.
 | 
| |\  
| | 
| |  | 
Correct spelling mistakes
 | 
| | |  | 
 | 
| | | 
| | 
| | 
| | 
| | 
| | 
| | 
| | 
| |  | 
Works around a bug in production:
  AttributeError: 'NoneType' object has no attribute 'replace'
  (datacite.py:724)
NOTE: there are no tests for this code path
 | 
| |/  
|   
|   
|   
|   
|   
|   
|   
|    | 
Example of entities with bogus years:
https://fatcat.wiki/release/search?q=doi_registrar%3Adatacite+year%3A%3E2100
We can do a clean-up task, but first need to prevent creation of new bad
metadata.
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
|  | 
Records from https://www.micropublication.org/ did not have a date in
FC, although raw data contained date strings - they were not using the
finer-grained "attributes.date" but "attributes.published" and/or
"attributes.publicationYear".
Support for those fields has been added, including a test case.
During this test (#30) a processing gap for names became clear (author
may have "given_name" and "surname", but no "name"). This bug has been
fixed, too.
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| | 
| 
| 
| 
| 
| 
|  | 
Use values from:
* attributes.creators[]
* attributes.contributors[]
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| |  | 
 | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
|  | 
The GBIF (https://www.gbif.org/) deposits most records under the titles:
* 599243 GBIF Occurrence Download
* 41176 Occurrence Download
Mark them as "stub" for the moment
(https://guide.fatcat.wiki/entity_release.html#release_type-vocabulary).
 | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
|  | 
* citeproc: http://docs.citationstyles.org/en/stable/specification.html#appendix-iii-types
* resourceTypeGeneral: https://schema.datacite.org/meta/kernel-4.0/doc/DataCite-MetadataKernel_v4.0.pdf#page=32
* resourceType: uncontrolled, over 170000 distinct values, frequent:
null, Dataset, JournalArticle, PGRFA Material, Journal Article,
Dataset/UNITE Species Hypothesis, ...
General frequency:
* "attributes.types": 18210075,
* "attributes.types.ris": 18058890,
* "attributes.types.bibtex": 18058888,
* "attributes.types.citeproc": 18058890,
* "attributes.types.schemaOrg": 18058929,
* "attributes.types.resourceType": 12737988,
* "attributes.types.resourceTypeGeneral": 16576139,
 | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
|  | 
* attributes.metadataVersion
* attributes.schemaVersion
* attributes.version (source dependent values, follows suggestions in
https://schema.datacite.org/meta/kernel-4.3/doc/DataCite-MetadataKernel_v4.3.pdf#page=26,
but values vary)
Furthermore:
* attributes.types.resourceTypeGeneral
* attributes.types.resourceType
 | 
| |  | 
 | 
| |  | 
 | 
| | 
| 
| 
| 
| 
|  | 
Set to `None` only if there is no publisher yet.
Docs: https://support.datacite.org/docs/doi-states
 | 
| |  | 
 | 
| | 
| 
| 
| 
|  | 
> include release_month as a top-level extra field [...] to
auto-populate the schema field from that
 | 
| | 
| 
| 
| 
| 
| 
| 
|  | 
Datacite defines placeholders for unknown values:
* https://support.datacite.org/docs/schema-values-unknown-information-v43
Clean abstracts.
 |