Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | importers: use clean_doi() in many more (all?) importers | Bryan Newbold | 2021-11-09 | 6 | -12/+29 |
| | |||||
* | clean_doi: stop mutating double-slash DOIs, except for 10.1037 prefix | Bryan Newbold | 2021-11-09 | 1 | -1/+2 |
| | |||||
* | remove deprecated extid sqlite3 lookup table feature from importers | Bryan Newbold | 2021-11-09 | 10 | -203/+10 |
| | | | | | | | | This was used during initial bulk imports, but is no longer used and could create serious metadata problems if used accidentially. In retrospect, it also made metadata provenance less transparent, and may have done more harm than good overall. | ||||
* | update CHANGELOG for recent development | Bryan Newbold | 2021-11-05 | 1 | -0/+26 |
| | |||||
* | python tests: verify array sort order | Bryan Newbold | 2021-11-05 | 4 | -20/+18 |
| | | | | | | | In a couple cases (eg, filesets), had made tests agnostic to sort order, because the sort order was not stable. In other cases, simply small cleanups and comment improvements. | ||||
* | api: add SQL 'ORDER BY' to many reads to stabilize API array ordering | Bryan Newbold | 2021-11-05 | 1 | -3/+14 |
| | | | | | | | | | | | | | | The hope is to make things like file entity URLs, fileset manifests, and other arrays in the JSON API "stable", meaning that if you create an entity with a list of a given order, a read back (in any environment, including prod/QA, bulk dumps, etc) will return the array with the same sort order. This was informally happening most of the time, but occasionally not (!) Assumption is that these sorts will have little or no performance impact, as the common case is less than a dozen elements, and the hard cases are a few thousand at most, and there is already a sorted index. | ||||
* | enable type annotation checking with flake8 by default ('make lint') | Bryan Newbold | 2021-11-03 | 1 | -4/+2 |
| | |||||
* | cleanups: create a separate JsonLinePusher for cleanup workers (distinct ↵ | Bryan Newbold | 2021-11-03 | 3 | -4/+20 |
| | | | | base class) | ||||
* | facat_import.py: work around corner case in run_cdl_dash_dat() | Bryan Newbold | 2021-11-03 | 1 | -1/+1 |
| | |||||
* | datacite importer: remove unused 'year_only' variable | Bryan Newbold | 2021-11-03 | 1 | -2/+3 |
| | |||||
* | web: work around remaining type annotation issues | Bryan Newbold | 2021-11-03 | 2 | -11/+15 |
| | |||||
* | ignore type errors in cors.py (third party code) | Bryan Newbold | 2021-11-03 | 1 | -2/+2 |
| | |||||
* | web: fix bytes/text warning logging | Bryan Newbold | 2021-11-03 | 1 | -3/+3 |
| | | | | Minor issue. Caught by type checking | ||||
* | lint: remove unused import | Bryan Newbold | 2021-11-03 | 1 | -1/+0 |
| | | | | This was caught by new linting, I think not caused by any recent changes | ||||
* | web config: add helper for coercing env vars into booleans | Bryan Newbold | 2021-11-03 | 1 | -3/+32 |
| | |||||
* | web: add type annotations | Bryan Newbold | 2021-11-03 | 12 | -297/+347 |
| | | | | | This commit does not include type fixes, only annotations. A small number of tuples were also converted to lists. | ||||
* | introduce 'AnyResponse' type for Flask views | Bryan Newbold | 2021-11-03 | 2 | -0/+15 |
| | |||||
* | pubmed harvester: remove unused variables | Bryan Newbold | 2021-11-03 | 1 | -2/+2 |
| | |||||
* | pubmed harvester: explicit assertions to mark unreachable code paths | Bryan Newbold | 2021-11-03 | 1 | -0/+2 |
| | |||||
* | typing: add assertions to fatcat_tool code to make type assumptions explicit | Bryan Newbold | 2021-11-03 | 3 | -0/+3 |
| | |||||
* | typing: add annotations to remaining fatcat_tools code | Bryan Newbold | 2021-11-03 | 9 | -122/+186 |
| | | | | | Again, these are just annotations, no changes made to get type checks to pass | ||||
* | datacite: add comment about potential date parsing bug | Bryan Newbold | 2021-11-03 | 1 | -0/+1 |
| | |||||
* | datacite importer: dateparser.date.DateDataParser() | Bryan Newbold | 2021-11-03 | 1 | -1/+1 |
| | | | | Perhaps this was a change when upgrading 'dateparser'? | ||||
* | more involved type wrangling and fixes for importers | Bryan Newbold | 2021-11-03 | 3 | -12/+14 |
| | |||||
* | typing: relatively simple type check fixes | Bryan Newbold | 2021-11-03 | 14 | -87/+82 |
| | | | | | | | These mostly add new variable names so that existing variables aren't overwritten with a new type; delay coercing '{}' or '[]' to 'None' until the last minute; adding is-not-None checks to conditional clauses; and similar small changes. | ||||
* | typing: initial annotations on importers | Bryan Newbold | 2021-11-03 | 22 | -274/+443 |
| | | | | | This commit just adds the type annotations, doesn't do fixes to code to make type checking pass. | ||||
* | typing: first batch of python bulk type annotations | Bryan Newbold | 2021-11-03 | 21 | -139/+200 |
| | | | | | | While these changes are more delicate than simple lint changes, this specific batch of edits and annotations was *relatively* simple, and resulted in few code changes other than function signature additions. | ||||
* | importers: remove unused __main__ routine | Bryan Newbold | 2021-11-03 | 4 | -19/+0 |
| | | | | | | These perhaps were used in initial develoment or testing? fatcat_import.py is the correct way to do these imports, even for testing/development. | ||||
* | lint: resolve existing mypy type errors | Bryan Newbold | 2021-11-02 | 12 | -81/+125 |
| | | | | | | | | | Adds annotations and re-workes dataflow to satisfy existing mypy issues, without adding any additional type annotations to, eg, function signatures. There will probably be many more type errors when annotations are all added. | ||||
* | web: annotate 'app' as 'Any', and document why | Bryan Newbold | 2021-11-02 | 1 | -1/+5 |
| | |||||
* | flake8 config: update ignore list after big fmt | Bryan Newbold | 2021-11-02 | 1 | -3/+4 |
| | |||||
* | re-fix some lint issues after big 'fmt' | Bryan Newbold | 2021-11-02 | 2 | -4/+5 |
| | |||||
* | fmt (black): fatcat_tools/ | Bryan Newbold | 2021-11-02 | 43 | -3194/+4020 |
| | |||||
* | fmt (black): fatcat_web/ | Bryan Newbold | 2021-11-02 | 13 | -1297/+1992 |
| | |||||
* | fmt (black): *.py | Bryan Newbold | 2021-11-02 | 11 | -715/+1110 |
| | |||||
* | fmt (black): tests/ | Bryan Newbold | 2021-11-02 | 55 | -1430/+1852 |
| | |||||
* | python: isort everything | Bryan Newbold | 2021-11-02 | 85 | -184/+278 |
| | |||||
* | revert '-vv' for pytest in Makefile (too verbose) | Bryan Newbold | 2021-11-02 | 1 | -1/+1 |
| | |||||
* | arabesque import 'hit' field is 1/0, not true/false | Bryan Newbold | 2021-11-02 | 1 | -2/+2 |
| | |||||
* | lint: simple, safe inline lint fixes | Bryan Newbold | 2021-11-02 | 39 | -221/+220 |
| | | | | '==' vs 'is'; 'not a in b' vs 'a not in b'; etc | ||||
* | lint/fmt: remove all 'import *' | Bryan Newbold | 2021-11-02 | 12 | -62/+207 |
| | |||||
* | entity transforms: add basic type annotations | Bryan Newbold | 2021-11-02 | 1 | -7/+19 |
| | |||||
* | ftfy 'fix_entities' argument has been renamed | Bryan Newbold | 2021-11-02 | 1 | -4/+4 |
| | |||||
* | hacks to work around new pylint false positives | Bryan Newbold | 2021-11-02 | 2 | -11/+18 |
| | |||||
* | cleanup imports after fatcat_tools.transforms change | Bryan Newbold | 2021-11-02 | 7 | -34/+76 |
| | |||||
* | re-fmt all the fatcat_tools __init__ files for readability | Bryan Newbold | 2021-11-02 | 5 | -30/+62 |
| | |||||
* | remove 'import *' from fatcat_tools (for transforms) | Bryan Newbold | 2021-11-02 | 1 | -2/+2 |
| | |||||
* | python makefile: tooling config updates | Bryan Newbold | 2021-11-02 | 1 | -12/+13 |
| | |||||
* | add pyproject.toml with isort configuration | Bryan Newbold | 2021-11-02 | 1 | -0/+3 |
| | |||||
* | pytest: more deprecation warning ignores | Bryan Newbold | 2021-11-02 | 1 | -0/+2 |
| |