diff options
author | Bryan Newbold <bnewbold@robocracy.org> | 2018-12-24 15:17:25 -0800 |
---|---|---|
committer | Bryan Newbold <bnewbold@robocracy.org> | 2018-12-24 15:17:25 -0800 |
commit | 24ab203a00354f768fc48e0786b21de4afcd9c4a (patch) | |
tree | 7c5305dafc110fb58e0ab323ba8b58c1f61914ba /rust | |
parent | d7a4e4649e1da2c02ec8472173c79f7c708ce19b (diff) | |
download | fatcat-24ab203a00354f768fc48e0786b21de4afcd9c4a.tar.gz fatcat-24ab203a00354f768fc48e0786b21de4afcd9c4a.zip |
implement release_year (and rustfmt)
Diffstat (limited to 'rust')
-rw-r--r-- | rust/migrations/2018-05-12-001226_init/up.sql | 9 | ||||
-rw-r--r-- | rust/src/api_entity_crud.rs | 34 | ||||
-rw-r--r-- | rust/src/api_helpers.rs | 22 | ||||
-rw-r--r-- | rust/src/api_server.rs | 6 | ||||
-rw-r--r-- | rust/src/database_models.rs | 2 | ||||
-rw-r--r-- | rust/src/database_schema.rs | 1 | ||||
-rw-r--r-- | rust/tests/test_api_server_http.rs | 76 |
7 files changed, 127 insertions, 23 deletions
diff --git a/rust/migrations/2018-05-12-001226_init/up.sql b/rust/migrations/2018-05-12-001226_init/up.sql index 7754b328..c842295e 100644 --- a/rust/migrations/2018-05-12-001226_init/up.sql +++ b/rust/migrations/2018-05-12-001226_init/up.sql @@ -196,6 +196,7 @@ CREATE TABLE release_rev ( release_type TEXT, -- TODO: enum release_status TEXT, -- TODO: enum release_date DATE, + release_year BIGINT, doi TEXT, -- CHECK for length limit for data quality pmid TEXT CHECK(octet_length(pmid) <= 12), @@ -430,10 +431,10 @@ INSERT INTO work_edit (ident_id, rev_id, redirect_id, editgroup_id, prev_rev) VA ('00000000-0000-0000-5555-000000000002', '00000000-0000-0000-5555-FFF000000002', null, '00000000-0000-0000-BBBB-000000000004', null), ('00000000-0000-0000-5555-000000000002', '00000000-0000-0000-5555-FFF000000003', null, '00000000-0000-0000-BBBB-000000000005', '00000000-0000-0000-5555-FFF000000002'); -INSERT INTO release_rev (id, work_ident_id, container_ident_id, title, release_type, release_status, release_date, doi, wikidata_qid, pmid, pmcid, isbn13, core_id, volume, issue, pages, publisher, language) VALUES - ('00000000-0000-0000-4444-FFF000000001', '00000000-0000-0000-5555-000000000001', null, 'example title', null, null, null, null, null, null, null, null, null, null, null, null, null, null), - ('00000000-0000-0000-4444-FFF000000002', '00000000-0000-0000-5555-000000000002', '00000000-0000-0000-1111-000000000001', 'bigger example', 'article-journal', null, '2018-01-01', '10.123/abc', 'Q55555', '54321', 'PMC555','978-3-16-148410-0', '42022773', '12', 'IV', '5-9', 'bogus publishing group', 'cn'), - ('00000000-0000-0000-4444-FFF000000003', '00000000-0000-0000-5555-000000000003', '00000000-0000-0000-1111-000000000003', 'Why Most Published Research Findings Are False', 'article-journal', 'published', '2005-08-30', '10.1371/journal.pmed.0020124', null, null, null, null, null, '2', '8', 'e124', 'Public Library of Science', 'en'); +INSERT INTO release_rev (id, work_ident_id, container_ident_id, title, release_type, release_status, release_date, release_year, doi, wikidata_qid, pmid, pmcid, isbn13, core_id, volume, issue, pages, publisher, language) VALUES + ('00000000-0000-0000-4444-FFF000000001', '00000000-0000-0000-5555-000000000001', null, 'example title', null, null, null, null, null, null, null, null, null, null, null, null, null, null, null), + ('00000000-0000-0000-4444-FFF000000002', '00000000-0000-0000-5555-000000000002', '00000000-0000-0000-1111-000000000001', 'bigger example', 'article-journal', null, '2018-01-01', 2018, '10.123/abc', 'Q55555', '54321', 'PMC555','978-3-16-148410-0', '42022773', '12', 'IV', '5-9', 'bogus publishing group', 'cn'), + ('00000000-0000-0000-4444-FFF000000003', '00000000-0000-0000-5555-000000000003', '00000000-0000-0000-1111-000000000003', 'Why Most Published Research Findings Are False', 'article-journal', 'published', '2005-08-30', 2005, '10.1371/journal.pmed.0020124', null, null, null, null, null, '2', '8', 'e124', 'Public Library of Science', 'en'); INSERT INTO release_ident (id, is_live, rev_id, redirect_id) VALUES ('00000000-0000-0000-4444-000000000001', true, '00000000-0000-0000-4444-FFF000000001', null), -- aaaaaaaaaaaaarceaaaaaaaaae diff --git a/rust/src/api_entity_crud.rs b/rust/src/api_entity_crud.rs index 792e6f9a..ee2d4ef3 100644 --- a/rust/src/api_entity_crud.rs +++ b/rust/src/api_entity_crud.rs @@ -166,7 +166,9 @@ macro_rules! generic_db_create_batch { ) -> Result<Vec<Self::EditRow>> { if models.iter().any(|m| m.redirect.is_some()) { return Err(ErrorKind::OtherBadRequest( - "can't create an entity that redirects from the start".to_string()).into()); + "can't create an entity that redirects from the start".to_string(), + ) + .into()); } let rev_ids: Vec<Uuid> = Self::db_insert_revs(conn, models)?; let ident_ids: Vec<Uuid> = insert_into($ident_table::table) @@ -658,7 +660,9 @@ impl EntityCrud for ContainerEntity { if models.iter().any(|m| m.name.is_none()) { return Err(ErrorKind::OtherBadRequest( - "name is required for all Container entities".to_string()).into()); + "name is required for all Container entities".to_string(), + ) + .into()); } let rev_ids: Vec<Uuid> = insert_into(container_rev::table) @@ -767,14 +771,16 @@ impl EntityCrud for CreatorEntity { if models.iter().any(|m| m.display_name.is_none()) { return Err(ErrorKind::OtherBadRequest( - "display_name is required for all Creator entities".to_string()).into()); + "display_name is required for all Creator entities".to_string(), + ) + .into()); } let rev_ids: Vec<Uuid> = insert_into(creator_rev::table) .values( models .iter() - .map(|model|CreatorRevNewRow { + .map(|model| CreatorRevNewRow { display_name: model.display_name.clone().unwrap(), // unwrapped checked above given_name: model.given_name.clone(), surname: model.surname.clone(), @@ -996,6 +1002,7 @@ impl EntityCrud for ReleaseEntity { release_type: None, release_status: None, release_date: None, + release_year: None, doi: None, pmid: None, pmcid: None, @@ -1029,7 +1036,7 @@ impl EntityCrud for ReleaseEntity { fn db_expand(&mut self, conn: &DbConn, expand: ExpandFlags) -> Result<()> { // Don't expand deleted entities if self.state == Some("deleted".to_string()) { - return Ok(()) + return Ok(()); } // TODO: should clarify behavior here. Would hit this path, eg, expanding files on a // release revision (not ident). Should we fail (Bad Request), or silently just not include @@ -1062,7 +1069,8 @@ impl EntityCrud for ReleaseEntity { contrib.creator = Some(CreatorEntity::db_get( conn, FatCatId::from_str(creator_id)?, - HideFlags::none())?); + HideFlags::none(), + )?); } } } @@ -1073,7 +1081,9 @@ impl EntityCrud for ReleaseEntity { fn db_create(&self, conn: &DbConn, edit_context: &EditContext) -> Result<Self::EditRow> { if self.redirect.is_some() { return Err(ErrorKind::OtherBadRequest( - "can't create an entity that redirects from the start".to_string()).into()); + "can't create an entity that redirects from the start".to_string(), + ) + .into()); } let mut edits = Self::db_create_batch(conn, edit_context, &[self])?; // probably a more elegant way to destroy the vec and take first element @@ -1089,7 +1099,9 @@ impl EntityCrud for ReleaseEntity { // of the release entities passed (at least in the common case) if models.iter().any(|m| m.redirect.is_some()) { return Err(ErrorKind::OtherBadRequest( - "can't create an entity that redirects from the start".to_string()).into()); + "can't create an entity that redirects from the start".to_string(), + ) + .into()); } // Generate the set of new work entities to insert (usually one for each release, but some @@ -1252,6 +1264,7 @@ impl EntityCrud for ReleaseEntity { release_type: rev_row.release_type, release_status: rev_row.release_status, release_date: rev_row.release_date, + release_year: rev_row.release_year, doi: rev_row.doi, pmid: rev_row.pmid, pmcid: rev_row.pmcid, @@ -1310,7 +1323,9 @@ impl EntityCrud for ReleaseEntity { if models.iter().any(|m| m.title.is_none()) { return Err(ErrorKind::OtherBadRequest( - "title is required for all Release entities".to_string()).into()); + "title is required for all Release entities".to_string(), + ) + .into()); } let rev_ids: Vec<Uuid> = insert_into(release_rev::table) @@ -1323,6 +1338,7 @@ impl EntityCrud for ReleaseEntity { release_type: model.release_type.clone(), release_status: model.release_status.clone(), release_date: model.release_date, + release_year: model.release_year, doi: model.doi.clone(), pmid: model.pmid.clone(), pmcid: model.pmcid.clone(), diff --git a/rust/src/api_helpers.rs b/rust/src/api_helpers.rs index 32750836..b837dfc2 100644 --- a/rust/src/api_helpers.rs +++ b/rust/src/api_helpers.rs @@ -22,7 +22,6 @@ pub struct EditContext { } impl EditContext { - /// This function should always be run within a transaction pub fn check(&self, conn: &DbConn) -> Result<()> { let count: i64 = changelog::table @@ -36,7 +35,6 @@ impl EditContext { } } - #[derive(Clone, Copy, PartialEq)] pub struct ExpandFlags { pub files: bool, @@ -456,11 +454,21 @@ pub fn check_sha256(raw: &str) -> Result<()> { #[test] fn test_check_sha256() { - assert!(check_sha256("cb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e452").is_ok()); - assert!(check_sha256("gb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e452").is_err()); - assert!(check_sha256("UB1C378F464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e452").is_err()); - assert!(check_sha256("cb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e45").is_err()); - assert!(check_sha256("cb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e4522").is_err()); + assert!( + check_sha256("cb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e452").is_ok() + ); + assert!( + check_sha256("gb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e452").is_err() + ); + assert!( + check_sha256("UB1C378F464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e452").is_err() + ); + assert!( + check_sha256("cb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e45").is_err() + ); + assert!( + check_sha256("cb1c378f464d5935ddaa8de28446d82638396c61f042295d7fb85e3cccc9e4522").is_err() + ); } pub fn check_release_type(raw: &str) -> Result<()> { diff --git a/rust/src/api_server.rs b/rust/src/api_server.rs index adc6ab11..d06de9c1 100644 --- a/rust/src/api_server.rs +++ b/rust/src/api_server.rs @@ -186,7 +186,7 @@ impl Server { .filter(file_ident::is_live.eq(true)) .filter(file_ident::redirect_id.is_null()) .first(conn)? - }, + } (None, Some(sha1), None) => { check_sha1(sha1)?; file_ident::table @@ -195,7 +195,7 @@ impl Server { .filter(file_ident::is_live.eq(true)) .filter(file_ident::redirect_id.is_null()) .first(conn)? - }, + } (None, None, Some(sha256)) => { check_sha256(sha256)?; file_ident::table @@ -204,7 +204,7 @@ impl Server { .filter(file_ident::is_live.eq(true)) .filter(file_ident::redirect_id.is_null()) .first(conn)? - }, + } _ => { return Err(ErrorKind::MissingOrMultipleExternalId("in lookup".to_string()).into()); } diff --git a/rust/src/database_models.rs b/rust/src/database_models.rs index d5daf9a4..617b150b 100644 --- a/rust/src/database_models.rs +++ b/rust/src/database_models.rs @@ -247,6 +247,7 @@ pub struct ReleaseRevRow { pub release_type: Option<String>, pub release_status: Option<String>, pub release_date: Option<chrono::NaiveDate>, + pub release_year: Option<i64>, pub doi: Option<String>, pub pmid: Option<String>, pub pmcid: Option<String>, @@ -270,6 +271,7 @@ pub struct ReleaseRevNewRow { pub release_type: Option<String>, pub release_status: Option<String>, pub release_date: Option<chrono::NaiveDate>, + pub release_year: Option<i64>, pub doi: Option<String>, pub pmid: Option<String>, pub pmcid: Option<String>, diff --git a/rust/src/database_schema.rs b/rust/src/database_schema.rs index 829a21b8..6c1fb929 100644 --- a/rust/src/database_schema.rs +++ b/rust/src/database_schema.rs @@ -211,6 +211,7 @@ table! { release_type -> Nullable<Text>, release_status -> Nullable<Text>, release_date -> Nullable<Date>, + release_year -> Nullable<Int8>, doi -> Nullable<Text>, pmid -> Nullable<Text>, pmcid -> Nullable<Text>, diff --git a/rust/tests/test_api_server_http.rs b/rust/tests/test_api_server_http.rs index 714cfc68..d6cdb6d3 100644 --- a/rust/tests/test_api_server_http.rs +++ b/rust/tests/test_api_server_http.rs @@ -586,6 +586,7 @@ fn test_post_release() { r#"{"title": "secret paper", "release_type": "article-journal", "release_date": "2000-01-02", + "release_year": 2000, "doi": "10.1234/abcde.781231231239", "pmid": "54321", "pmcid": "PMC12345", @@ -1230,6 +1231,81 @@ fn test_release_dates() { None, ); + // Ok + check_http_response( + request::post( + "http://localhost:9411/v0/release", + headers.clone(), + r#"{"title": "secret minimal paper", + "release_type": "article-journal", + "release_year": 2000 + }"#, + &router, + ), + status::Created, + None, + ); + + // Ok; ISO 8601 + check_http_response( + request::post( + "http://localhost:9411/v0/release", + headers.clone(), + r#"{"title": "secret minimal paper", + "release_type": "article-journal", + "release_year": -100 + }"#, + &router, + ), + status::Created, + None, + ); + check_http_response( + request::post( + "http://localhost:9411/v0/release", + headers.clone(), + r#"{"title": "secret minimal paper", + "release_type": "article-journal", + "release_year": 0 + }"#, + &router, + ), + status::Created, + None, + ); + + // Ok + check_http_response( + request::post( + "http://localhost:9411/v0/release", + headers.clone(), + r#"{"title": "secret minimal paper", + "release_type": "article-journal", + "release_date": "2000-01-02", + "release_year": 2000 + }"#, + &router, + ), + status::Created, + None, + ); + + // Ok for now, but may be excluded later + check_http_response( + request::post( + "http://localhost:9411/v0/release", + headers.clone(), + r#"{"title": "secret minimal paper", + "release_type": "article-journal", + "release_date": "2000-01-02", + "release_year": 1999 + }"#, + &router, + ), + status::Created, + None, + ); + // Bad: year/month only check_http_response( request::post( |