diff options
| author | Bryan Newbold <bnewbold@robocracy.org> | 2020-09-17 20:00:51 -0700 |
|---|---|---|
| committer | Bryan Newbold <bnewbold@robocracy.org> | 2020-09-17 20:00:55 -0700 |
| commit | 6e1c91d5e66f8cd54fa22fc17a688f25839ca3ce (patch) | |
| tree | c1f919efceb36b11372ee7efbb361b93795578a8 /python/tests | |
| parent | 257f5b55e6d35893dfdf8c5306842db5bb076f3e (diff) | |
| download | fatcat-6e1c91d5e66f8cd54fa22fc17a688f25839ca3ce.tar.gz fatcat-6e1c91d5e66f8cd54fa22fc17a688f25839ca3ce.zip | |
web: route constraints on fcids and UUIDs
Instead of accepting any string for these parameters and throwing a 400
error if not the correct type, implement better route matching at the
framework level and return more 404s.
This resolves several outstanding sentry exceptions.
The "flask-uuid" was imported and seems to have been configured for this
purpose previously, but I guess I never finished configuring it.
Diffstat (limited to 'python/tests')
| -rw-r--r-- | python/tests/web_entity_views.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/python/tests/web_entity_views.py b/python/tests/web_entity_views.py index 7b973ef2..4068a0c7 100644 --- a/python/tests/web_entity_views.py +++ b/python/tests/web_entity_views.py @@ -48,7 +48,7 @@ def test_entity_basics(app, mocker): rv = app.get('/{}/rev/{}'.format(entity_type, revision)) assert rv.status_code == 200 rv = app.get('/{}/rev/{}_something'.format(entity_type, revision)) - assert rv.status_code == 400 + assert rv.status_code == 404 rv = app.get('/{}/rev/{}/metadata'.format(entity_type, revision)) assert rv.status_code == 200 print('/editgroup/aaaaaaaaaaaabo53aaaaaaaaaq/{}/{}'.format(entity_type, ident)) @@ -59,11 +59,13 @@ def test_entity_basics(app, mocker): # bad requests rv = app.get('/{}/9999999999'.format(entity_type)) - assert rv.status_code == 400 + assert rv.status_code == 404 rv = app.get('/{}/9999999999/history'.format(entity_type)) - assert rv.status_code == 400 + assert rv.status_code == 404 rv = app.get('/{}/f1f046a3-45c9-ffff-ffff-ffffffffffff'.format(entity_type)) - assert rv.status_code == 400 + assert rv.status_code == 404 + rv = app.get('/{}/rev/f1f046a3-45c9-ffff-ffff-fffffffff'.format(entity_type)) + assert rv.status_code == 404 rv = app.get('/{}/ccccccccccccccccccccccccca'.format(entity_type)) assert rv.status_code == 404 |