diff options
author | Bryan Newbold <bnewbold@robocracy.org> | 2019-05-21 11:25:03 -0700 |
---|---|---|
committer | Bryan Newbold <bnewbold@robocracy.org> | 2019-05-21 11:41:29 -0700 |
commit | 9688cedac61729bc417a3cb31096f52bdb6f16db (patch) | |
tree | 4a504fec129547c107e47316bf5e25560f810ca8 /python/tests | |
parent | 0ec3fc58b4394102ffaaf385e6048a6412a9c9b7 (diff) | |
download | fatcat-9688cedac61729bc417a3cb31096f52bdb6f16db.tar.gz fatcat-9688cedac61729bc417a3cb31096f52bdb6f16db.zip |
JSTOR importer polish
Diffstat (limited to 'python/tests')
-rw-r--r-- | python/tests/import_jstor.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/python/tests/import_jstor.py b/python/tests/import_jstor.py index b1b86a44..019f0aae 100644 --- a/python/tests/import_jstor.py +++ b/python/tests/import_jstor.py @@ -56,22 +56,22 @@ def test_jstor_xml_parse(jstor_importer): assert r.release_type == "abstract" assert r.release_stage == "published" assert r.license_slug == None - # XXX: assert r.ext_ids.doi == "10.2307/111039" + assert r.ext_ids.doi == None assert r.ext_ids.jstor == "111039" assert r.language == "en" assert r.volume == "5" assert r.issue == None assert r.pages == "831-832" - # TODO: None if published jan 1st? - assert str(r.release_date) == "1843-01-01" + # None because jan 1st + assert r.release_date == None assert r.release_year == 1843 # matched by ISSN, so shouldn't be in there? #assert extra['container_name'] == "Abstracts of the Papers Communicated to the Royal Society of London" assert len(r.contribs) == 1 - # XXX: extra['jstor'] stuff + assert r.extra['jstor']['journal_ids'] == ['abstpapecommroya', 'j100687'] assert r.contribs[0].raw_name == "John Kinnersley Smythies" assert r.contribs[0].given_name == "John Kinnersley" assert r.contribs[0].surname == "Smythies" - assert not r.refs + assert r.refs == None |