aboutsummaryrefslogtreecommitdiffstats
path: root/python/tests
diff options
context:
space:
mode:
authorMartin Czygan <martin@archive.org>2020-07-24 10:11:37 +0000
committerMartin Czygan <martin@archive.org>2020-07-24 10:11:37 +0000
commit8b00843af1366cf019c896057706ace4afff27ba (patch)
tree86fc58bf26f07e272aa27e989f3ab6b4cfef2090 /python/tests
parent2170e5ff46dfb2bba9bf26196de3c3774c16cd4a (diff)
parentfc93f35996cab23984d9a45f1a411b8776e437bf (diff)
downloadfatcat-8b00843af1366cf019c896057706ace4afff27ba.tar.gz
fatcat-8b00843af1366cf019c896057706ace4afff27ba.zip
Merge branch 'bnewbold-more-lint-fixes' into 'master'
more lint fixes See merge request webgroup/fatcat!69
Diffstat (limited to 'python/tests')
-rw-r--r--python/tests/api_annotations.py4
-rw-r--r--python/tests/api_editgroups.py1
-rw-r--r--python/tests/api_entity_state.py2
-rw-r--r--python/tests/api_releases.py2
-rw-r--r--python/tests/import_ingest.py2
5 files changed, 5 insertions, 6 deletions
diff --git a/python/tests/api_annotations.py b/python/tests/api_annotations.py
index 0606b637..79acaa4b 100644
--- a/python/tests/api_annotations.py
+++ b/python/tests/api_annotations.py
@@ -30,5 +30,5 @@ def test_annotations(api):
if thing.annotation_id == a[0].annotation_id:
found = thing
break
- assert thing
- assert thing.extra['thing'] == "thang"
+ assert found
+ assert found.extra['thing'] == "thang"
diff --git a/python/tests/api_editgroups.py b/python/tests/api_editgroups.py
index 142687c2..b4420b29 100644
--- a/python/tests/api_editgroups.py
+++ b/python/tests/api_editgroups.py
@@ -98,7 +98,6 @@ def test_editgroup_auto_batch(api):
def test_batch_params(api):
- eg = quick_eg(api)
c1 = CreatorEntity(display_name="test auto_batch")
c2 = CreatorEntity(display_name="test another auto_batch")
diff --git a/python/tests/api_entity_state.py b/python/tests/api_entity_state.py
index d5ba6301..4b49083e 100644
--- a/python/tests/api_entity_state.py
+++ b/python/tests/api_entity_state.py
@@ -359,7 +359,7 @@ def test_self_redirect(api):
c1_redirect = CreatorEntity(redirect=c1.ident)
eg = quick_eg(api)
with pytest.raises(fatcat_openapi_client.rest.ApiException):
- merge_edit = api.update_creator(eg.editgroup_id, c1.ident, c1_redirect)
+ api.update_creator(eg.editgroup_id, c1.ident, c1_redirect)
def test_wip_redirect(api):
diff --git a/python/tests/api_releases.py b/python/tests/api_releases.py
index c4c05ea6..9c70f655 100644
--- a/python/tests/api_releases.py
+++ b/python/tests/api_releases.py
@@ -177,7 +177,7 @@ def test_empty_fields(api):
title="something",
contribs=[ReleaseContrib(raw_name="somebody")],
ext_ids=ReleaseExtIds())
- r1edit = api.create_release(eg.editgroup_id, r1)
+ api.create_release(eg.editgroup_id, r1)
with pytest.raises(fatcat_openapi_client.rest.ApiException):
r2 = ReleaseEntity(title="", ext_ids=ReleaseExtIds())
diff --git a/python/tests/import_ingest.py b/python/tests/import_ingest.py
index ebe2923c..4a46232a 100644
--- a/python/tests/import_ingest.py
+++ b/python/tests/import_ingest.py
@@ -63,7 +63,7 @@ def test_ingest_importer_stage(ingest_importer, api):
eg = quick_eg(api)
r1 = api.lookup_release(doi="10.123/abc")
r1.release_stage = row['release_stage']
- c1 = api.update_release(eg.editgroup_id, r1.ident, r1)
+ api.update_release(eg.editgroup_id, r1.ident, r1)
api.accept_editgroup(eg.editgroup_id)
# set ingest request stage