diff options
author | Bryan Newbold <bnewbold@robocracy.org> | 2018-11-15 13:11:52 -0800 |
---|---|---|
committer | Bryan Newbold <bnewbold@robocracy.org> | 2018-11-15 13:15:15 -0800 |
commit | bb28a3fc1cc900f2dde31e1dbc492d9661034f41 (patch) | |
tree | f037dd3d1bab6cbf08a562dbdd4c09361fe0c030 /python/tests | |
parent | 9f817c6c70a749f2ac449ab4edfd26c6dd8a7410 (diff) | |
download | fatcat-bb28a3fc1cc900f2dde31e1dbc492d9661034f41.tar.gz fatcat-bb28a3fc1cc900f2dde31e1dbc492d9661034f41.zip |
large refactor of python names/paths
- Add __init__.py files for fatcat_tools submodules, and use them in
imports
- Add a bunch of comments to files.
- rename a number of classes and functions to be less verbose
Diffstat (limited to 'python/tests')
-rw-r--r-- | python/tests/import_crossref.py | 4 | ||||
-rw-r--r-- | python/tests/import_grobid_metadata.py | 4 | ||||
-rw-r--r-- | python/tests/import_issn.py | 4 | ||||
-rw-r--r-- | python/tests/import_matched.py | 4 | ||||
-rw-r--r-- | python/tests/import_orcid.py | 4 | ||||
-rw-r--r-- | python/tests/importer.py | 2 | ||||
-rw-r--r-- | python/tests/transform_tests.py | 7 |
7 files changed, 14 insertions, 15 deletions
diff --git a/python/tests/import_crossref.py b/python/tests/import_crossref.py index 078db184..c129e729 100644 --- a/python/tests/import_crossref.py +++ b/python/tests/import_crossref.py @@ -1,13 +1,13 @@ import json import pytest -from fatcat_tools.importers.crossref import FatcatCrossrefImporter +from fatcat_tools.importers import CrossrefImporter @pytest.fixture(scope="function") def crossref_importer(): with open('tests/files/ISSN-to-ISSN-L.snip.txt', 'r') as issn_file: - yield FatcatCrossrefImporter("http://localhost:9411/v0", issn_file, 'tests/files/example_map.sqlite3') + yield CrossrefImporter("http://localhost:9411/v0", issn_file, 'tests/files/example_map.sqlite3') def test_crossref_importer_batch(crossref_importer): with open('tests/files/crossref-works.2018-01-21.badsample.json', 'r') as f: diff --git a/python/tests/import_grobid_metadata.py b/python/tests/import_grobid_metadata.py index 8b268e21..ee7040c9 100644 --- a/python/tests/import_grobid_metadata.py +++ b/python/tests/import_grobid_metadata.py @@ -3,7 +3,7 @@ import os import json import base64 import pytest -from fatcat_tools.importers.grobid_metadata import FatcatGrobidMetadataImporter +from fatcat_tools.importers import GrobidMetadataImporter """ WARNING: these tests are currently very fragile because they have database @@ -12,7 +12,7 @@ side-effects. Should probably be disabled or re-written. @pytest.fixture(scope="function") def grobid_metadata_importer(): - yield FatcatGrobidMetadataImporter("http://localhost:9411/v0") + yield GrobidMetadataImporter("http://localhost:9411/v0") # TODO: use API to check that entities actually created... #def test_grobid_metadata_importer_batch(grobid_metadata_importer): diff --git a/python/tests/import_issn.py b/python/tests/import_issn.py index f45747ed..98a9f4a7 100644 --- a/python/tests/import_issn.py +++ b/python/tests/import_issn.py @@ -1,11 +1,11 @@ import pytest -from fatcat_tools.importers.issn import FatcatIssnImporter +from fatcat_tools.importers import IssnImporter @pytest.fixture(scope="function") def issn_importer(): - yield FatcatIssnImporter("http://localhost:9411/v0") + yield IssnImporter("http://localhost:9411/v0") # TODO: use API to check that entities actually created... def test_issn_importer_batch(issn_importer): diff --git a/python/tests/import_matched.py b/python/tests/import_matched.py index 8004e3bd..85e21267 100644 --- a/python/tests/import_matched.py +++ b/python/tests/import_matched.py @@ -1,12 +1,12 @@ import json import pytest -from fatcat_tools.importers.matched import FatcatMatchedImporter +from fatcat_tools.importers import MatchedImporter @pytest.fixture(scope="function") def matched_importer(): - yield FatcatMatchedImporter("http://localhost:9411/v0") + yield MatchedImporter("http://localhost:9411/v0") # TODO: use API to check that entities actually created... def test_matched_importer_batch(matched_importer): diff --git a/python/tests/import_orcid.py b/python/tests/import_orcid.py index 2dc98d76..18199888 100644 --- a/python/tests/import_orcid.py +++ b/python/tests/import_orcid.py @@ -1,12 +1,12 @@ import json import pytest -from fatcat_tools.importers.orcid import FatcatOrcidImporter +from fatcat_tools.importers import OrcidImporter @pytest.fixture(scope="function") def orcid_importer(): - yield FatcatOrcidImporter("http://localhost:9411/v0") + yield OrcidImporter("http://localhost:9411/v0") # TODO: use API to check that entities actually created... def test_orcid_importer_batch(orcid_importer): diff --git a/python/tests/importer.py b/python/tests/importer.py index d98638e4..f228a9b2 100644 --- a/python/tests/importer.py +++ b/python/tests/importer.py @@ -1,7 +1,7 @@ import pytest -from fatcat_tools.importers.common import FatcatImporter +from fatcat_tools.importers import FatcatImporter def test_issnl_mapping_lookup(): diff --git a/python/tests/transform_tests.py b/python/tests/transform_tests.py index 52a9965a..18522eff 100644 --- a/python/tests/transform_tests.py +++ b/python/tests/transform_tests.py @@ -1,15 +1,14 @@ import json import pytest -from fatcat_tools.importers.crossref import FatcatCrossrefImporter -from fatcat_tools.transforms import * +from fatcat_tools import * from import_crossref import crossref_importer -def test_elastic_convert(crossref_importer): +def test_elasticsearch_convert(crossref_importer): with open('tests/files/crossref-works.single.json', 'r') as f: # not a single line raw = json.loads(f.read()) (r, c) = crossref_importer.parse_crossref_dict(raw) r.state = 'active' - release_elastic_dict(r) + release_to_elasticsearch(r) |