Merge branch 'bnewbold-citeproc-fixes' into 'master'

improve citeproc/CSL web interface

See merge request webgroup/fatcat!36

1 files changed, 43 insertions, 3 deletions

diff --git a/python/tests/web_citation_csl.py b/python/tests/web_citation_csl.py
index 3279ebea..e016b2d9 100644
--- a/python/tests/web_citation_csl.py
+++ b/python/tests/web_citation_csl.py
@@ -6,7 +6,7 @@ from fatcat_openapi_client.rest import ApiException
 from fixtures import *
 
 
-def test_release_bibtex(app):
+def test_release_bibtex(app, api):
 
     # "realistic" demo entity
     rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaam')
@@ -17,6 +17,8 @@ def test_release_bibtex(app):
     assert b'@article{' in rv.data
     rv = app.get('/release/ccccccccccccccccccccccccca.bib')
     assert rv.status_code == 404
+    rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaam/citeproc?style=bibtex')
+    assert rv.status_code == 200
     rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaam/citeproc?style=csl-json')
     assert rv.status_code == 200
     # could also rv.get_json() here
@@ -25,10 +27,48 @@ def test_release_bibtex(app):
     assert rv.status_code == 200
     assert rv.data.decode('utf-8').startswith('Ioannidis, John. “Why Most Published Research Findings Are False”. 2.8 (2005)')
 
-    # "dummy" demo entity
+    # "dummy" demo entity; very minimal metadata
     rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaai')
     assert rv.status_code == 200
+    assert b'BibTeX' in rv.data
+    rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaai.bib')
+    assert rv.status_code == 200
+    rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaai/citeproc?style=modern-language-association')
+    assert rv.status_code == 200
+    rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaai/citeproc?style=csl-json')
+    assert rv.status_code == 200
+
+    # create release which can not have citeproc run on it (no authors)
+    eg = quick_eg(api)
+    r1 = ReleaseEntity(
+        title="some title",
+        ext_ids=ReleaseExtIds(),
+    )
+    r1edit = api.create_release(eg.editgroup_id, r1)
+    api.accept_editgroup(eg.editgroup_id)
+
+    rv = app.get('/release/{}'.format(r1edit.ident))
+    assert rv.status_code == 200
     assert not b'BibTeX' in rv.data
     with pytest.raises(ValueError):
-        rv = app.get('/release/aaaaaaaaaaaaarceaaaaaaaaai.bib')
+        rv = app.get('/release/{}.bib'.format(r1edit.ident))
+
+    # create release can have citeproc run on it (no authors)
+    eg = quick_eg(api)
+    r2 = ReleaseEntity(
+        title="some title again",
+        contribs=[
+            ReleaseContrib(
+                given_name="Paul",
+                surname="Otlet"),
+        ],
+        ext_ids=ReleaseExtIds(),
+    )
+    r2edit = api.create_release(eg.editgroup_id, r2)
+    api.accept_editgroup(eg.editgroup_id)
 
+    rv = app.get('/release/{}'.format(r2edit.ident))
+    assert rv.status_code == 200
+    assert b'BibTeX' in rv.data
+    rv = app.get('/release/{}.bib'.format(r2edit.ident))
+    assert rv.status_code == 200