aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBryan Newbold <bnewbold@robocracy.org>2018-08-30 20:02:26 -0700
committerBryan Newbold <bnewbold@robocracy.org>2018-08-30 20:02:26 -0700
commit8cccbcdef11e7ddc761ec494cb894a8d49a0d510 (patch)
tree21e9f35f80a69dbc18fbafa86c55c3f8b787133a
parent6006c7406716ae15d0101a8980a2ae955de71690 (diff)
downloadfatcat-8cccbcdef11e7ddc761ec494cb894a8d49a0d510.tar.gz
fatcat-8cccbcdef11e7ddc761ec494cb894a8d49a0d510.zip
autoaccept notes
-rw-r--r--notes/autoaccept_api.txt31
1 files changed, 31 insertions, 0 deletions
diff --git a/notes/autoaccept_api.txt b/notes/autoaccept_api.txt
new file mode 100644
index 00000000..b7e0a824
--- /dev/null
+++ b/notes/autoaccept_api.txt
@@ -0,0 +1,31 @@
+
+Currently only on batch creation (POST) for entities.
+
+For all bulk operations, optional 'editgroup' query parameter overrides
+individual editgroup parameters.
+
+If autoaccept flag is set and editgroup is not, a new editgroup is
+automatically created and overrides for all entities inserted. Note
+that this is different behavior from the "use current or create new"
+default behavior for regular creation.
+
+Unfortunately, "true" and "false" are the only values acceptable for boolean
+rust/openapi2 query parameters
+
+THOUGHT: doing an UPDATE in a transaction is probably not expensive
+
+Intent:
+- check can_autoaccept flag on editor table
+
+---------
+
+Crude benchmarking...
+
+cat /data/crossref/crossref-works.2018-01-21.badsample_5k.json | time ./fatcat_import.py import-crossref - /data/issn/20180216.ISSN-to-ISSN-L.txt
+
+autoaccept: 7.47user 0.48system 0:30.64elapsed 25%CPU
+master: 5.70user 0.34system 0:25.61elapsed 23%CPU
+ batch creation: ~153ms+
+ accept: ~5ms
+
+uh...