diff options
| author | Bryan Newbold <bnewbold@robocracy.org> | 2019-05-20 15:01:30 -0700 |
|---|---|---|
| committer | Bryan Newbold <bnewbold@robocracy.org> | 2019-05-20 15:01:30 -0700 |
| commit | 9f25c2b4bd1e600448512fa6c4553acb6a3d92d6 (patch) | |
| tree | 08bf839164397f8191a3949e245ecd3beb5aa0a9 | |
| parent | 510dc33c55b1aa993fc3e0e7085184ecbda8ef04 (diff) | |
| download | fatcat-9f25c2b4bd1e600448512fa6c4553acb6a3d92d6.tar.gz fatcat-9f25c2b4bd1e600448512fa6c4553acb6a3d92d6.zip | |
make some XXX into TODO
| -rw-r--r-- | python/fatcat_tools/transforms/csl.py | 4 | ||||
| -rw-r--r-- | python/tests/transform_csl.py | 2 | ||||
| -rw-r--r-- | rust/src/endpoint_handlers.rs | 1 | ||||
| -rw-r--r-- | rust/tests/test_api_server_http.rs | 2 | ||||
| -rw-r--r-- | rust/tests/test_auth.rs | 2 |
5 files changed, 5 insertions, 6 deletions
diff --git a/python/fatcat_tools/transforms/csl.py b/python/fatcat_tools/transforms/csl.py index 079e0501..989629ab 100644 --- a/python/fatcat_tools/transforms/csl.py +++ b/python/fatcat_tools/transforms/csl.py @@ -14,7 +14,7 @@ from fatcat_client import ApiClient def contribs_by_role(contribs, role): ret = [c.copy() for c in contribs if c['role'] == role] [c.pop('role') for c in ret] - # XXX: + # TODO: some note to self here [c.pop('literal') for c in ret if 'literal' in c] if not ret: return None @@ -83,7 +83,7 @@ def release_to_csl(entity): csl = dict( #id, #categories - type=entity.release_type or "article", # XXX: can't be blank + type=entity.release_type or "article", # can't be blank language=entity.language, #journalAbbreviation #shortTitle diff --git a/python/tests/transform_csl.py b/python/tests/transform_csl.py index 43f7a99d..9601f19b 100644 --- a/python/tests/transform_csl.py +++ b/python/tests/transform_csl.py @@ -44,7 +44,7 @@ def test_csl_pubmed_bibtex(crossref_importer): r = entity_from_json(f.readline(), ReleaseEntity) csl = release_to_csl(r) print(citeproc_csl(csl, 'bibtex')) - # XXX: what's with the '`' in volume? + # TODO: what's with the '`' in volume? assert citeproc_csl(csl, 'bibtex').strip() == """ @article{mędrela-kuder_szymura_2018, title={Selected anti-health behaviours among women with osteoporosis}, diff --git a/rust/src/endpoint_handlers.rs b/rust/src/endpoint_handlers.rs index 5c22e21d..4253af45 100644 --- a/rust/src/endpoint_handlers.rs +++ b/rust/src/endpoint_handlers.rs @@ -37,7 +37,6 @@ macro_rules! entity_auto_batch_handler { let _clr: ChangelogRow = diesel::insert_into(changelog::table) .values((changelog::editgroup_id.eq(edit_context.editgroup_id.to_uuid()),)) .get_result(conn)?; - // XXX: edits.into_iter().map(|e| e.into_model()).collect() self.get_editgroup_handler(conn, editgroup_id) } } diff --git a/rust/tests/test_api_server_http.rs b/rust/tests/test_api_server_http.rs index d88af31c..c5ec8eca 100644 --- a/rust/tests/test_api_server_http.rs +++ b/rust/tests/test_api_server_http.rs @@ -863,7 +863,7 @@ fn test_post_release() { ); // TODO: "secret paper" // Bogus non-existant fields - /* XXX: doesn't fail + /* TODO: doesn't fail helpers::check_http_response( request::post( &format!("http://localhost:9411/v0/editgroup/{}/release", editgroup_id), diff --git a/rust/tests/test_auth.rs b/rust/tests/test_auth.rs index a9e7cbb0..c684490f 100644 --- a/rust/tests/test_auth.rs +++ b/rust/tests/test_auth.rs @@ -47,6 +47,6 @@ fn test_auth_db() { auth::revoke_tokens(&conn, editor_id).unwrap(); // verification should fail - // XXX: one-second slop breaks this + // TODO: one-second slop breaks this //assert!(c.parse_macaroon_token(&conn, &token, None).is_err()); } |