diff options
| author | Bryan Newbold <bnewbold@robocracy.org> | 2020-11-20 13:27:21 -0800 |
|---|---|---|
| committer | Bryan Newbold <bnewbold@robocracy.org> | 2020-11-20 13:27:23 -0800 |
| commit | 4e0f8bd7796eaa419490c082bbf92558a39c0718 (patch) | |
| tree | 83167374e30146ebdd2a9b1c0405c16a252ccb06 | |
| parent | 7160cf4d43983014289cda7aed076ca1a6b431be (diff) | |
| download | fatcat-4e0f8bd7796eaa419490c082bbf92558a39c0718.tar.gz fatcat-4e0f8bd7796eaa419490c082bbf92558a39c0718.zip | |
crossref+datacite: remove confusing early update bail
Easy to miss that we skip updates *twice*, and with this early bailout
were not updating counts correctly.
| -rw-r--r-- | python/fatcat_tools/importers/crossref.py | 2 | ||||
| -rw-r--r-- | python/fatcat_tools/importers/datacite.py | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/python/fatcat_tools/importers/crossref.py b/python/fatcat_tools/importers/crossref.py index 71f08952..e77fa65e 100644 --- a/python/fatcat_tools/importers/crossref.py +++ b/python/fatcat_tools/importers/crossref.py @@ -487,8 +487,6 @@ class CrossrefImporter(EntityImporter): except fatcat_openapi_client.rest.ApiException as err: if err.status != 404: raise err - # doesn't exist, need to update - return True # eventually we'll want to support "updates", but for now just skip if # entity already exists diff --git a/python/fatcat_tools/importers/datacite.py b/python/fatcat_tools/importers/datacite.py index 5cdc5577..70f8db86 100644 --- a/python/fatcat_tools/importers/datacite.py +++ b/python/fatcat_tools/importers/datacite.py @@ -781,8 +781,6 @@ class DataciteImporter(EntityImporter): except fatcat_openapi_client.rest.ApiException as err: if err.status != 404: raise err - # doesn't exist, need to update - return True # eventually we'll want to support "updates", but for now just skip if # entity already exists |