summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorBryan Newbold <bnewbold@archive.org>2021-10-27 18:24:19 -0700
committerBryan Newbold <bnewbold@archive.org>2021-10-27 18:25:58 -0700
commit560d5f7cc1672f95e2a953ab5908f4205151a703 (patch)
tree04b35084358786bbd2329491be07cde35a4d2289 /tests
parent33211915773a0c77d064c55c1b02ceed6f455feb (diff)
downloadfatcat-scholar-560d5f7cc1672f95e2a953ab5908f4205151a703.tar.gz
fatcat-scholar-560d5f7cc1672f95e2a953ab5908f4205151a703.zip
refactor use of grobid_tei_xml
Diffstat (limited to 'tests')
-rw-r--r--tests/test_grobid_parse.py (renamed from tests/test_grobid2json.py)33
-rw-r--r--tests/test_refs_transform.py3
2 files changed, 33 insertions, 3 deletions
diff --git a/tests/test_grobid2json.py b/tests/test_grobid_parse.py
index adf36a1..c0adf9b 100644
--- a/tests/test_grobid2json.py
+++ b/tests/test_grobid_parse.py
@@ -1,7 +1,7 @@
from grobid_tei_xml import parse_document_xml
-def test_grobid_parse() -> None:
+def test_grobid_parse_legacy() -> None:
"""
This function formerly tested the grobid2json file in this project. Now it
tests backwards-compatibility of the grobid_tei_xml library.
@@ -29,3 +29,34 @@ def test_grobid_parse() -> None:
ref["unstructured"]
== "Tasa K, Baker R, Murray M. Using patient feedback for qua- lity improvement. Quality Management in Health Care 1996;8:206-19."
)
+
+
+def test_grobid_parse() -> None:
+ """
+ Equivalent to test_grobid_parse_legacy(), but using the GrobidDocument type directly
+ """
+
+ with open("tests/files/example_grobid.tei.xml", "r") as f:
+ blob = f.read()
+
+ doc = parse_document_xml(blob)
+
+ assert (
+ doc.header.title
+ == "Changes of patients' satisfaction with the health care services in Lithuanian Health Promoting Hospitals network"
+ )
+
+ assert doc.citations is not None
+ ref = [c for c in doc.citations if c.id == "b12"][0]
+ assert ref.authors[0].given_name == "K"
+ assert ref.authors[0].full_name == "K Tasa"
+ assert ref.authors[0].surname == "Tasa"
+ assert ref.journal == "Quality Management in Health Care"
+ assert ref.title == "Using patient feedback for quality improvement"
+ assert ref.date == "1996"
+ assert ref.pages == "206-225"
+ assert ref.volume == "8"
+ assert (
+ ref.unstructured
+ == "Tasa K, Baker R, Murray M. Using patient feedback for qua- lity improvement. Quality Management in Health Care 1996;8:206-19."
+ )
diff --git a/tests/test_refs_transform.py b/tests/test_refs_transform.py
index 2fc210f..4b1b588 100644
--- a/tests/test_refs_transform.py
+++ b/tests/test_refs_transform.py
@@ -20,8 +20,7 @@ def test_transform_refs_grobid() -> None:
)
tei_doc = parse_document_xml(blob)
- tei_dict = tei_doc.to_legacy_dict()
- refs = refs_from_grobid(dummy_release, tei_dict)
+ refs = refs_from_grobid(dummy_release, tei_doc)
ref = refs[12]
assert ref.release_ident == "releasedummy22222222222222"