From ea64cc1dc7033a1ede57f6bc278030429addeef9 Mon Sep 17 00:00:00 2001 From: ludwig Date: Sun, 31 Dec 2006 15:36:42 +0000 Subject: fix buffer overflow and format string bug in auth server response processing git-svn-id: svn://svn.icculus.org/quake3/trunk@1025 edf5b092-35ff-0310-97b2-ce42778d08ea --- code/server/sv_client.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'code/server') diff --git a/code/server/sv_client.c b/code/server/sv_client.c index 5685457..3a4a74b 100644 --- a/code/server/sv_client.c +++ b/code/server/sv_client.c @@ -149,7 +149,6 @@ void SV_AuthorizeIpPacket( netadr_t from ) { int i; char *s; char *r; - char ret[1024]; if ( !NET_CompareBaseAdr( from, svs.authorizeAddress ) ) { Com_Printf( "SV_AuthorizeIpPacket: not from authorize server\n" ); @@ -195,8 +194,7 @@ void SV_AuthorizeIpPacket( netadr_t from ) { if (!r) { NET_OutOfBandPrint( NS_SERVER, svs.challenges[i].adr, "print\nAwaiting CD key authorization\n" ); } else { - sprintf(ret, "print\n%s\n", r); - NET_OutOfBandPrint( NS_SERVER, svs.challenges[i].adr, ret ); + NET_OutOfBandPrint( NS_SERVER, svs.challenges[i].adr, "print\n%s\n", r); } // clear the challenge record so it won't timeout and let them through Com_Memset( &svs.challenges[i], 0, sizeof( svs.challenges[i] ) ); @@ -207,8 +205,7 @@ void SV_AuthorizeIpPacket( netadr_t from ) { if (!r) { NET_OutOfBandPrint( NS_SERVER, svs.challenges[i].adr, "print\nSomeone is using this CD Key\n" ); } else { - sprintf(ret, "print\n%s\n", r); - NET_OutOfBandPrint( NS_SERVER, svs.challenges[i].adr, ret ); + NET_OutOfBandPrint( NS_SERVER, svs.challenges[i].adr, "print\n%s\n", r ); } // clear the challenge record so it won't timeout and let them through -- cgit v1.2.3