From a679ae64e0a659e2b94ec97e688633bc1a0d041e Mon Sep 17 00:00:00 2001 From: thilo Date: Sat, 6 May 2006 01:56:24 +0000 Subject: Add string length checking to function COM_StripExtension. This fixes the R_RemapShader buffer overflow exploit that can be found here: http://milw0rm.com/exploits/1750 git-svn-id: svn://svn.icculus.org/quake3/trunk@765 edf5b092-35ff-0310-97b2-ce42778d08ea --- code/qcommon/vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'code/qcommon/vm.c') diff --git a/code/qcommon/vm.c b/code/qcommon/vm.c index 0eb35c5..efc0da8 100644 --- a/code/qcommon/vm.c +++ b/code/qcommon/vm.c @@ -230,7 +230,7 @@ void VM_LoadSymbols( vm_t *vm ) { return; } - COM_StripExtension( vm->name, name ); + COM_StripExtension(vm->name, name, sizeof(name)); Com_sprintf( symbols, sizeof( symbols ), "vm/%s.map", name ); len = FS_ReadFile( symbols, (void **)&mapfile ); if ( !mapfile ) { -- cgit v1.2.3