From cc92797003bd83af10e6ddec04b62a6c0f3ab7df Mon Sep 17 00:00:00 2001 From: Bryan Newbold Date: Fri, 28 Sep 2018 13:27:34 -0700 Subject: sprinkle in TODOs for crossref importer --- python/fatcat/crossref_importer.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/python/fatcat/crossref_importer.py b/python/fatcat/crossref_importer.py index 10efe59c..bab3fe2f 100644 --- a/python/fatcat/crossref_importer.py +++ b/python/fatcat/crossref_importer.py @@ -160,6 +160,7 @@ class FatcatCrossrefImporter(FatcatImporter): for key in ('subject', 'type', 'license', 'alternative-id', 'container-title', 'original-title', 'subtitle', 'archive', 'funder', 'group-title'): + # TODO: unpack "container-title" array val = obj.get(key) if val: extra[key] = val @@ -169,6 +170,7 @@ class FatcatCrossrefImporter(FatcatImporter): extra['license'][i]['start'] = extra['license'][i]['start']['date-time'] if len(obj['title']) > 1: extra['other-titles'] = obj['title'][1:] + # TODO: this should be top-level extra['is_kept'] = len(obj.get('archive', [])) > 0 # ISBN -- cgit v1.2.3