From 4f5d992bd75823e03ef64a77104b4ddee08aaf12 Mon Sep 17 00:00:00 2001 From: Bryan Newbold Date: Fri, 15 Mar 2019 16:17:51 -0700 Subject: HACK: force pylint to ignore urllib3 Retry import As the code comment mentions, not sure why pylint throws this error. requests and urllib3 are recent, and this code runs fine in tests and QA, and pylint is running (in CI) within pipenv. --- python/fatcat_tools/harvest/harvest_common.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/fatcat_tools/harvest/harvest_common.py b/python/fatcat_tools/harvest/harvest_common.py index 11fd5fe8..4a71a655 100644 --- a/python/fatcat_tools/harvest/harvest_common.py +++ b/python/fatcat_tools/harvest/harvest_common.py @@ -5,7 +5,9 @@ import time import datetime import requests from requests.adapters import HTTPAdapter -from requests.packages.urllib3.util.retry import Retry +# unclear why pylint chokes on this import. Recent 'requests' and 'urllib3' are +# in Pipenv.lock, and there are no errors in QA +from requests.packages.urllib3.util.retry import Retry # pylint: disable=import-error # Used for parsing ISO date format (YYYY-MM-DD) -- cgit v1.2.3